[POS Orders] Order details improvements in larger accessibility sizes #15880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salesChannelLabel had a higher hugging priority, preferring to stay as small as its content allows -> resists growing while subtitleLabel (within the same horizontal stack) does, truncating the badge on larger accessibility sizes. We apply lower hugging to the “other” label (that’s the subtitle one), as well as more compression resistance to the label that shouldn’t be compressed (that’s the pos label)
iamgabrielma
added
type: task
Collaborator
|
|
Base automatically changed from
task/WOOMOB-709-make-sales-channel-filter
to
trunk
July 8, 2025 11:25
joshheald
approved these changes
Jul 9, 2025
Contributor
joshheald
left a comment
joshheald
left a comment
There was a problem hiding this comment.
Work, but the tall POS badge when the order date goes to two lines is strange.
You can fix it by changing the stack view's alignment: it's currently Fill, but Top or Center are probably better choices here.
Collaborator
Contributor
Author
Thanks for the tip, aligning .top looks much better when the date happens to be extra long 👍 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-751
Description
When using the app in large accessibility sizes, both order details and order list have shown some wonkiness, which among other issues cuts/truncates the
POSbadge.This PR addresses the order details side (only) by adjusting
SummaryTableViewCell's xib file hugging and compression priorities for the subtitle label for the date and the sales channel label, so now it does not truncate but both are kept on screen.I've attempted to adjust order details as well in this PR but is quite messier, and while it leaves us 80% there is still not quite right. I'll give it another go using a different approach separately via a
HostingTableViewCelland rewriting the cell in SwiftUI to see if that is better.Testing information
created_viaproperty, go to the POS tab and pay for a POS order.Screen.Recording.2025-07-08.at.13.05.58.mov
In phone: